[feat] Check and fix duplicated figure/table chunk labels#486
Open
sbreitbart-NOAA wants to merge 2 commits into
Open
[feat] Check and fix duplicated figure/table chunk labels#486sbreitbart-NOAA wants to merge 2 commits into
sbreitbart-NOAA wants to merge 2 commits into
Conversation
…docs, and if present, comments out duplicates (as per #451)
Contributor
Checklist
|
Contributor
New version checklist
|
Contributor
Code Metrics Report
Code coverage of files in pull request scope (55.2%)
Reported by octocov |
Collaborator
|
I'm going to tag team on this and make checks for duplicate rda's/images as well and have both issues solved in one. I tested this out and I think this is a good start, but it does a couple of thing (1) I think the commenting out is a good solution, but I am going to add a check to see if the same image is loaded in. In the case it is, the the chunk will be removed/won't be added. In the case it's not, I think it would be better to rename the label with a 1 or other alternative so it's still accessible to the user (2) I will adjust the lapply or a loop to go through the chunks and make sure ones that have already been added are not added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
fix_duplicate_chunks()function in utilsDoes the PR impact any other area of the project, maybe another repo?