Fix HUD vanishing after closing the Instant Actions menu#8
Open
pgfrank1 wants to merge 2 commits into
Open
Conversation
StardewUI's menu (DocumentViewMenu) sets Game1.displayHUD = false while open and never restores it on close. Because the radial wheel has already closed by the time that menu opens, StarControl's own HUD save/restore never covers it, so the HUD stayed hidden after closing Instant Actions -- and the latched-off value then poisoned the wheel's HUD capture on the next open, requiring F4 to recover. Capture the HUD state in OpenRemappingMenu and restore it via the menu controller's Closing event (the cleanupBeforeExit lifecycle hook that fires at actual close time; Closed fires at open). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Deploy target copied StarControl.Gmcm.dll to $(SolutionDir)StarControl/assets/extensions, which assumes the solution sits beside the StarControl project. In a monorepo where the .sln lives elsewhere, this created a stray StarControl/ folder at the solution root and the extension never reached the deployed mod, so keybinding sync silently failed with "GMCM extension not found". Deploy directly into the game's deployed mod folder via $(GameModsPath), which is exactly where StarControl loads it from at runtime (Helper.DirectoryPath/assets/extensions/StarControl.Gmcm.dll). Guarded on GameModsPath being set so a CI build without a game install won't fail. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StardewUI's menu (DocumentViewMenu) sets Game1.displayHUD = false while open and never restores it on close. Because the radial wheel has already closed by the time that menu opens, StarControl's own HUD save/restore never covers it, so the HUD stayed hidden after closing Instant Actions -- and the latched-off value then poisoned the wheel's HUD capture on the next open, requiring F4 to recover.
Capture the HUD state in OpenRemappingMenu and restore it via the menu controller's Closing event (the cleanupBeforeExit lifecycle hook that fires at actual close time; Closed fires at open).