feat: add proton-pass plugin#4
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Noctalia Launcher plugin (proton-pass) that integrates with the Proton Pass CLI to browse vaults/items and copy passwords (optionally showing TOTP notifications). It also adds a Zed editor configuration file, which is currently inconsistent with the PR description/checklist.
Changes:
- Add new
proton-passlauncher provider that shells out topass-clito list vaults/items and copy secrets. - Add initial plugin metadata (
plugin.toml) and user-facing documentation (README.md). - Add
.zed/settings.jsonfor Luau LSP configuration (but it currently references a missing definition file).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| proton-pass/README.md | Documents the new Proton Pass launcher plugin features and requirements. |
| proton-pass/plugin.toml | Declares plugin metadata, dependencies, and launcher provider entrypoint. |
| proton-pass/launcher.luau | Implements vault/item browsing and activation behavior via Proton Pass CLI calls. |
| .zed/settings.json | Adds Zed Luau LSP settings (currently misaligned with repo contents and PR checklist). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a9625d6 to
2f5578a
Compare
| -- Entry points ---------------------------------------------------------------- | ||
|
|
||
| function onQuery(query: string) | ||
| local vault, rest = query:match("^(%S+)%s+(.*)$") |
| local id: { type: string, id: string } = noctalia.json.decode(_id) | ||
|
|
||
| if id.type == "vault" then | ||
| launcher.setQuery(`{PREFIX} {id.id} `) |
|
Since |
|
|
||
| -- Try to fetch TOTP and notify | ||
| getItemTotpAsync(item, function(totp) | ||
| noctalia.notify(`{item.title} TOTP`, totp) |
There was a problem hiding this comment.
I don't think "TOTP" needs to be translated, that's just the technical term for this kind of code.
90444fe to
8bbc141
Compare
|
Thanks for the quick turn around due to the recent changes! |
Plugin
lucasoe/proton-passplugin.toml)What it does
Adds integration for the Proton Pass CLI to the launcher. Allows browsing Vaults and their content. Passwords can be copied to the clipboard. TOTP codes are shown as a notification if they exist.
External dependencies
Testing
Screenshots / Videos
2026-07-13_21-38-46.mp4
Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.versionfollows semver and is bumped in this PR;min_noctaliais the version I tested against.translations/en.json(no machine-translated locales).catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
licensedeclared inplugin.toml.