feat: port test_exception to CTS - #43
Merged
Merged
Conversation
Contributor
Author
|
@kraenhansen This turned out to be tricky, as this needs to verify an uncaughtException. Thus, forcing another level of process spawning to verify. |
Member
|
This one is tricky, as I don't expect implementors such as emnapi and React Native to support this from their harness implementation 🤔 |
Contributor
Author
|
@kraenhansen A priority list would have helped. I'm just picking up from the list sequentially. |
Contributor
Author
|
depends on #54 |
Member
|
@bavulapati similarly to this comment I suggest moving this into draft until the parent PR merge. |
kraenhansen
marked this pull request as draft
April 26, 2026 08:30
bavulapati
force-pushed
the
feat/port-test-exception
branch
from
June 29, 2026 12:35
4dfac05 to
94d6582
Compare
bavulapati
force-pushed
the
feat/port-test-exception
branch
from
July 14, 2026 08:10
94d6582 to
fc17c54
Compare
bavulapati
marked this pull request as ready for review
July 14, 2026 08:12
legendecas
reviewed
Jul 17, 2026
legendecas
reviewed
Jul 17, 2026
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
legendecas
reviewed
Jul 20, 2026
|
|
||
| // GC until the finalizer fires; the counter just bounds the loop. | ||
| let gcCount = 10; | ||
| await gcUntil('test', () => --gcCount <= 0); |
Member
There was a problem hiding this comment.
gcUntil has a counter already. This can be optimized to check until onUncaughtException is invoked.
legendecas
approved these changes
Jul 24, 2026
Member
|
This has a conflict. |
…ption # Conflicts: # PORTING.md
legendecas
approved these changes
Aug 7, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ports
test_exception from Node.js test suite to the CTS.