lib,src,test,doc: add node:ffi module#62072
Draft
cjihrig wants to merge 8 commits intonodejs:mainfrom
Draft
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Member
|
Yes |
Qard
reviewed
Mar 2, 2026
Member
Qard
left a comment
Qard
left a comment
There was a problem hiding this comment.
Looks very cool! I'm glad to see someone has picked this back up. 🙂
I did a quick review and it all looks good. My only comment is there seems to be a bunch of static strings and a private symbol which we might want to define in env_properties.h.
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
github-actions
bot
added
request-ci-failed
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/23272564448 |
Collaborator
anonrig
previously approved these changes
Mar 18, 2026
anonrig
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
Author
|
@anonrig I cancelled that CI run to save resources. I started https://ci.nodejs.org/job/node-test-pull-request/71877/ manually, and it's currently running. |
jasnell
dismissed
anonrig’s stale review
given that this is still draft and @cjihrig indicated it's not ready for review, a sign off is not yet appropriate.
mcollina
added
request-ci
Collaborator
jasnell
dismissed
mcollina’s stale review
given that this is still draft and @cjihrig indicated it's not ready for review, a sign off is not yet appropriate.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ready for review yet. Just opening to see if this is something the project is still interested in.