Skip to content

test_runner: set non-zero exit code when suite errors occur#62282

Open
geeksilva97 wants to merge 2 commits intonodejs:mainfrom
geeksilva97:fix/describe-error-exit-code
Open

test_runner: set non-zero exit code when suite errors occur#62282
geeksilva97 wants to merge 2 commits intonodejs:mainfrom
geeksilva97:fix/describe-error-exit-code

Conversation

@geeksilva97
Copy link
Contributor

Fixes #58687

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 16, 2026
@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (4579957) to head (4328ac8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62282      +/-   ##
==========================================
+ Coverage   89.67%   89.68%   +0.01%     
==========================================
  Files         676      676              
  Lines      206555   206558       +3     
  Branches    39554    39555       +1     
==========================================
+ Hits       185230   185254      +24     
+ Misses      13461    13449      -12     
+ Partials     7864     7855       -9     
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 62.19% <100.00%> (+0.17%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2026
@nodejs-github-bot
Copy link
Collaborator

@geeksilva97 geeksilva97 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

errors thrown in describe() do not set non-zero exitCode (and do not fail CI)

6 participants