stream: fix writev unhandled rejection in fromWeb

[Han5991]

Summary

Fixes #62199

When using Duplex.fromWeb() or Writable.fromWeb() with cork()/uncork(), writes are batched into _writev(). If destroy() is called in the same microtask (after uncork()), the underlying WritableStream writer gets aborted, causing SafePromiseAll() to reject with a non-array value (e.g. an AbortError or null).

The done() callback in _writev() of both newStreamDuplexFromReadableWritablePair and newStreamWritableFromWritableStream unconditionally called error.filter(), assuming the value was always an array from SafePromiseAll. This caused a TypeError: Cannot read properties of null (reading 'filter') that became an unhandled rejection, crashing the process.

Root cause

done was used as both the resolve and reject handler for SafePromiseAll:

PromisePrototypeThen(SafePromiseAll(chunks, ...), done, done);

• Resolve path: done([undefined, undefined, ...]) — array, .filter() works
• Reject path: done(abortError) or done(null) — non-array, .filter() throws

Fix

Separate the resolve and reject handlers of SafePromiseAll. Promise.all resolving means all writes succeeded — there is no error to report. Promise.all rejecting passes a single error value directly.

PromisePrototypeThen(SafePromiseAll(chunks, ...), () => done(), done);

• () => done() — resolve path: all writes succeeded, call callback with no error
• done — reject path: single error passed directly to callback

The same fix is applied to both newStreamDuplexFromReadableWritablePair and newStreamWritableFromWritableStream.

Test

Added test/parallel/test-webstreams-duplex-fromweb-writev-unhandled-rejection.js with the exact reproduction from the issue report (cork → write → write → uncork → destroy).

[Renegade334]

#62291 is already open (although I believe the approach here is the correct one)

[Han5991]

Agreed — and since #62291 is already open, I've opened this as a separate issue because I believe the approach here is the correct one. @Renegade334

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.66%. Comparing base (b4ea323) to head (1af4a4a).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/adapters.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #62297   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         676      676           
  Lines      206564   206574   +10     
  Branches    39559    39554    -5     
=======================================
+ Hits       185223   185232    +9     
- Misses      13454    13471   +17     
+ Partials     7887     7871   -16     

Files with missing lines	Coverage Δ
lib/internal/webstreams/adapters.js	86.60% <75.00%> (+0.30%)	⬆️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.