Skip to content

Revert "quic: complete the internal implementation of QUIC"#63148

Closed
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:quic-revert
Closed

Revert "quic: complete the internal implementation of QUIC"#63148
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:quic-revert

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 6, 2026

See #62876 (comment), without this revert coverage GHA job always fail, preventing other PRs to land

This reverts commit cf91d18.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 72 hours to land. label May 6, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/net
  • @nodejs/quic
  • @nodejs/security-wg

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 6, 2026
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels May 6, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 61.15385% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (e80b5d2) to head (93a098b).

Files with missing lines Patch % Lines
lib/internal/quic/state.js 23.25% 66 Missing ⚠️
src/node_sockaddr.cc 86.40% 9 Missing and 8 partials ⚠️
lib/internal/quic/stats.js 47.61% 11 Missing ⚠️
src/node_blob.cc 64.70% 2 Missing and 4 partials ⚠️
src/dataqueue/queue.cc 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63148      +/-   ##
==========================================
+ Coverage   89.66%   89.69%   +0.03%     
==========================================
  Files         713      712       -1     
  Lines      224076   221240    -2836     
  Branches    42308    42387      +79     
==========================================
- Hits       200912   198446    -2466     
+ Misses      14996    14616     -380     
- Partials     8168     8178      +10     
Files with missing lines Coverage Δ
lib/internal/blob.js 99.45% <100.00%> (+10.13%) ⬆️
lib/internal/errors.js 97.64% <ø> (-0.01%) ⬇️
lib/internal/fs/promises.js 92.94% <ø> (-0.01%) ⬇️
lib/internal/perf/observe.js 91.55% <ø> (+0.12%) ⬆️
lib/internal/quic/quic.js 100.00% <ø> (ø)
lib/internal/quic/symbols.js 100.00% <100.00%> (ø)
src/debug_utils.h 80.00% <ø> (ø)
src/node_blob.h 37.50% <ø> (ø)
src/node_file.h 78.43% <ø> (ø)
src/node_sockaddr.h 38.23% <ø> (ø)
... and 6 more

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
Copy link
Copy Markdown
Member

jasnell commented May 6, 2026

Simpler Alternative: #63149

Copy link
Copy Markdown
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#63149 is a better alternative and is closer to passing CI.

@jasnell
Copy link
Copy Markdown
Member

jasnell commented May 6, 2026

Superseded by #63149

@jasnell jasnell closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs that do not need to wait for 72 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants