module: exclude node:ffi from builtinModules when flag is disabled#63158
Open
ljharb wants to merge 1 commit intonodejs:mainfrom
Open
module: exclude node:ffi from builtinModules when flag is disabled#63158ljharb wants to merge 1 commit intonodejs:mainfrom
ljharb wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
798219d to
999efeb
Compare
aduh95
approved these changes
May 6, 2026
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Collaborator
targos
approved these changes
May 6, 2026
Contributor
|
Related failure to address: |
panva
approved these changes
May 6, 2026
JakobJingleheimer
approved these changes
May 6, 2026
Collaborator
lpinca
approved these changes
May 6, 2026
Module.builtinModules is supposed to only list modules that are accessible to user code. node:ffi requires --experimental-ffi to be required, so filter it out when the flag is not set, mirroring the existing handling for --experimental-quic. Refs: nodejs#63137 (comment) Signed-off-by: Jordan Harband <ljharb@gmail.com>
bengl
approved these changes
May 6, 2026
Member
Author
|
@aduh95 thanks, fixed! |
cc2a346 to
29fb725
Compare
Collaborator
Member
Author
|
the CI failure looks spurious? |
Contributor
|
It's a bit annoying that you force-pushed my commit out, it seems unlikely there will be time to include this PR in 26.1.0 now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module.builtinModulesis supposed to only list modules that are accessible to user code. node:ffi requires--experimental-ffito be required, so filter it out when the flag is not set, mirroring the existing handling for--experimental-quic.Refs: #63137 (comment), #62072