doc: fix keepAliveTimeout default in http.createServer options#63974
doc: fix keepAliveTimeout default in http.createServer options#63974jahanzaib-iqbal-dev wants to merge 1 commit into
Conversation
|
Review requested:
|
nodejs-github-bot
added
doc
pimterry
left a comment
pimterry
left a comment
There was a problem hiding this comment.
Good catch, thanks! Change itself looks good, but your commit message is failing linting because it doesn't have a signed-off-by trailer. You'll need to git commit -s --amend (which will add the trailer) and then force push.
PR nodejs#62782 updated the keepAliveTimeout default from 5s to 65s and correctly updated server.keepAliveTimeout (line 2006), but the http.createServer() options table at line 3775 was not updated. Fix the remaining reference to reflect the current default of 65000ms. Signed-off-by: Jahanzaib iqbal <jahanzaib@gsoftconsulting.com>
jahanzaib-iqbal-dev
force-pushed
the
docs/fix-keepalivetimeout-default
branch
from
2e7f41b to
f15a17a
Compare
|
@pimterry thanks for the review! I've added the |
bjohansebas
added
the
author ready
|
@lpinca would you mind taking a look? We have 3 approvals and all CI checks are green — just needs a core collaborator review to land. 🙏 |
Thanks for fixing the commit, I've reapproved the updated version now. It's not quite as simple as this though - PRs also need to wait for at least 48 hours minimum (with 2 core collaborator approvals) before merging to give time for anybody to object, or wait 7 days if there's just one approval. That means this can now merge in 6 days if nothing else happens, or tomorrow if any other collaborators approves in the meantime. |
6 participants
PR #62782 updated the
keepAliveTimeoutdefault from 5 seconds to 65 seconds and correctly updated theserver.keepAliveTimeoutproperty section, but thehttp.createServer()options table was not updated and still shows**Default:** \5000``.This PR fixes the remaining reference.
Before:
After: