ffi: fix float passing in libffi for riscv64#63976
Closed
kxxt wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Review requested:
|
Member
Author
|
It appears that there is some problem with NixOS binary cache that causes CI to fail. |
10 tasks
libffi was incorrectly passing floats as doubles on RISC-V. This PR applies the merged upstream fix (libffi/libffi#972) for the vendored copy of libffi since libffi appears to have a very long release cycle (last release was at 2025-08-02). This fixes the following three new test failures: test/ffi/test-ffi-dynamic-library.js test/ffi/test-ffi-shared-buffer.js test/ffi/test-ffi-calls.js Signed-off-by: Levi Zim <rsworktech@outlook.com>
Member
Author
|
I have rebased this PR to fix the flaky test in the CI (#63923). |
Contributor
|
I think this will be handled by #64040 which seems to include this fix. Do you think we can close this? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libffi was incorrectly passing floats as doubles on RISC-V. This PR applies the merged upstream fix (libffi/libffi#972) for the vendored copy of libffi since libffi appears to have a very long release cycle (last release was at 2025-08-02).
This fixes the following three new test failures caught in https://github.com/riscv-forks/node-riscv/actions/runs/27544719447/job/81437248188:
CC @nodejs/platform-riscv64
I am testing this PR on riscv64 at https://github.com/riscv-forks/node-riscv/actions/runs/27756747452/job/82120430409?pr=4