-
-
Notifications
You must be signed in to change notification settings - Fork 36.4k
test: add a simple test for import defer of a CJS module
#64694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MayaLekova
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
MayaLekova:import-defer-04-cjs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,25 @@ | ||||||||||||
| // Flags: --js-defer-import-eval | ||||||||||||
|
|
||||||||||||
| // Test that uses import.defer for a CJS module. It ensures that: | ||||||||||||
| // 1. the module is imported successfully | ||||||||||||
| // 2. it's evaluated synchronously, regardless of the `defer` modifier. | ||||||||||||
|
|
||||||||||||
| import '../common/index.mjs'; | ||||||||||||
| import * as assert from 'assert'; | ||||||||||||
|
|
||||||||||||
| // Import the CJS module with the `defer` modifier. | ||||||||||||
| import defer * as imported from '../fixtures/es-modules/module-cjs-deferred-eval.js'; | ||||||||||||
|
|
||||||||||||
| globalThis.eval_list = []; | ||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
|
|
||||||||||||
| // Check that the exported properties are accessible and have the | ||||||||||||
|
joyeecheung marked this conversation as resolved.
|
||||||||||||
| // expected values. | ||||||||||||
|
Comment on lines
+15
to
+16
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
This is a bit self-evident. |
||||||||||||
| assert.strictEqual(imported.foo, 42); | ||||||||||||
| assert.strictEqual(imported.identifier, 'package-type-commonjs'); | ||||||||||||
|
|
||||||||||||
| // Check that the module has been evaluated at this point, | ||||||||||||
| // also that it's not evaluated more than once. | ||||||||||||
| assert.deepStrictEqual(['defer-1'], globalThis.eval_list); | ||||||||||||
|
|
||||||||||||
| // Clean-up | ||||||||||||
| delete globalThis.eval_list; | ||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // This fixture is imported as a module | ||
| // in test/es-module/test-cjs-defer-static-import-eval.mjs | ||
| // to ensure a CommonJS module imported with `import defer` | ||
| // is only executed once. | ||
| const assert = require('assert'); | ||
|
|
||
| const identifier = 'package-type-commonjs'; | ||
|
|
||
| module.exports.foo = 42; | ||
| module.exports.identifier = identifier; | ||
|
|
||
| // The `eval_list` is initialised by the importing module, | ||
| // so by the time the fixture is executed, `eval_list` should | ||
| // already be initialised. | ||
| assert.deepEqual(globalThis.eval_list, []); | ||
|
|
||
| globalThis.eval_list.push('defer-1'); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.