test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960
Closed
panva wants to merge 2 commits into
Closed
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960panva wants to merge 2 commits into
panva wants to merge 2 commits into
Conversation
panva
added
the
commit-queue-rebase
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
panva
added
test
aduh95
reviewed
Aug 2, 2026
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 759 759
Lines 247634 247635 +1
Branches 46687 46680 -7
=======================================
+ Hits 223623 223635 +12
- Misses 15462 15465 +3
+ Partials 8549 8535 -14
🚀 New features to boost your workflow:
|
panva
force-pushed
the
actions-fips
branch
2 times, most recently
from
August 3, 2026 12:39
68ba143 to
5699e8d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
reviewed
Aug 4, 2026
aduh95
reviewed
Aug 4, 2026
aduh95
reviewed
Aug 4, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Member
Author
Thank you for your help |
Contributor
Changelog@@ -1162,0 +1163,14 @@
+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)
+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)
+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)
+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)
+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)
+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)
+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)
+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)
+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)
+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)
+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)
+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)
+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)
+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux) |
panva
added
request-ci
avivkeller
approved these changes
Aug 4, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b79dcdf...dc7838c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).
Closes: #48379