tools: add fallback cleanup job for CQ - #65005
Open
aduh95 wants to merge 1 commit into
Open
Conversation
In case of cancellation (e.g. timeout) occuring while the CQ was dealing with a PR, we likely want the PR back into the queue. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
avivkeller
reviewed
Aug 5, 2026
| done | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| PRs: ${{ needs.get_mergeable_prs.outputs.numbers }} |
Member
There was a problem hiding this comment.
Rather than re-adding the label, why don't we change the CQ to not remove it until it either completes or fails (reducing our calls to the GitHub API)
concurrency: ${{ github.workflow }}
This line would prevent a PR from being picked up twice, so I see no harm in waiting to remove the label
Contributor
Author
There was a problem hiding this comment.
The consequence would be there would be merged PRs with the label, but yeah I'm not sure if that's actually an issue. Feel free to push to this branch or open an alternative PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of cancellation (e.g. timeout) occuring while the CQ was dealing with a PR, we likely want the PR back into the queue.
Refs: #64972