Update event-loop-timers-and-nexttick.md#8611
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
|
Bump @nodejs/timers |
|
@slavamuravey please rebase |
|
@avivkeller Rebased |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8611 +/- ##
==========================================
+ Coverage 75.27% 75.28% +0.01%
==========================================
Files 105 105
Lines 9242 9242
Branches 326 326
==========================================
+ Hits 6957 6958 +1
+ Misses 2283 2282 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
@slavamuravey Quality check failed. Could you format the files with |
Signed-off-by: Viacheslav Muravyev <slavamuravey@mail.ru> Update event-loop-timers-and-nexttick.md
|
@araujogui |
|
@nodejs/collaborators @nodejs/timers can you also take a look here? |
I investigated libuv
uv_runfunction and libuv Design overview section and I propose to correct Node.js documentation related with event loop phases order.It is a common misconception to think that the timer phase is the first one. Actually, it is the last one within event loop iteration.