Skip to content

Update event-loop-timers-and-nexttick.md#8611

Merged
avivkeller merged 1 commit intonodejs:mainfrom
slavamuravey:patch-1
Mar 24, 2026
Merged

Update event-loop-timers-and-nexttick.md#8611
avivkeller merged 1 commit intonodejs:mainfrom
slavamuravey:patch-1

Conversation

@slavamuravey
Copy link
Contributor

@slavamuravey slavamuravey commented Feb 8, 2026

I investigated libuv uv_run function and libuv Design overview section and I propose to correct Node.js documentation related with event loop phases order.
It is a common misconception to think that the timer phase is the first one. Actually, it is the last one within event loop iteration.

@slavamuravey slavamuravey requested a review from a team as a code owner February 8, 2026 07:36
@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Mar 24, 2026 7:48am

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nodejs/timers

@avivkeller
Copy link
Member

Bump @nodejs/timers

@avivkeller
Copy link
Member

@slavamuravey please rebase

@slavamuravey
Copy link
Contributor Author

@avivkeller Rebased

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.28%. Comparing base (7ec1349) to head (2eff870).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8611      +/-   ##
==========================================
+ Coverage   75.27%   75.28%   +0.01%     
==========================================
  Files         105      105              
  Lines        9242     9242              
  Branches      326      326              
==========================================
+ Hits         6957     6958       +1     
+ Misses       2283     2282       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@araujogui
Copy link
Member

@slavamuravey Quality check failed. Could you format the files with pnpm prettier:fix?

Signed-off-by: Viacheslav Muravyev <slavamuravey@mail.ru>

Update event-loop-timers-and-nexttick.md
@slavamuravey
Copy link
Contributor Author

@araujogui pnpm prettier:fix done

@araujogui
Copy link
Member

araujogui commented Mar 24, 2026

@nodejs/collaborators @nodejs/timers can you also take a look here?

@avivkeller avivkeller added this pull request to the merge queue Mar 24, 2026
Merged via the queue into nodejs:main with commit 197b989 Mar 24, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants