Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow to run zizmor for security analysis of this repository’s GitHub Actions configuration, aligning with the referenced web-team security initiative.
Changes:
- Introduces a new workflow that runs on
pushandpull_requesttomain. - Uses pinned SHAs for
actions/checkoutandzizmorcore/zizmor-action.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
|
🤔 I don't see this having run on this PR? I would imagine there will be a lot of changes to other workflows required before Zizmor can pass? |
.github/workflows/zizmor.yml
Outdated
| @@ -0,0 +1,25 @@ | |||
| name: GitHub Actions Security Analysis with zizmor 🌈 | |||
There was a problem hiding this comment.
This seems like an excessively long title to show up in our PR checks?
I copied this workflow from Zizmor's documentation, I can, of course, remove that trigger. Im not sure if it will fail PRs, or just report them as having security concerns. Perhaps I should push another commit with the fixes to the issues it would find? |
|
We're also going to want a branch ruleset change I imagine to block PRs where we have Zizmor failings if we're using the advanced security mode? |
It will just report them unless we add a new rule. But, I don't see it running at all? It would show up as a passing Actions check still as it is being run on the PR trigger? |
It won't run on this PR, since it's the one that added it (GitHub is weird that way) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8728 +/- ##
==========================================
- Coverage 75.12% 75.07% -0.06%
==========================================
Files 104 104
Lines 9167 9167
Branches 315 316 +1
==========================================
- Hits 6887 6882 -5
- Misses 2278 2283 +5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Ref: nodejs/web-team#113
Ref: https://openjs-foundation.slack.com/archives/C0ALRN98G8K/p1773689960844809 (🔒)