Skip to content

Require matplotlib < 3.8 for pgf.common_texification#597

Open
JasonGross wants to merge 1 commit into
nschloe:mainfrom
JasonGross:patch-1
Open

Require matplotlib < 3.8 for pgf.common_texification#597
JasonGross wants to merge 1 commit into
nschloe:mainfrom
JasonGross:patch-1

Conversation

@JasonGross

Copy link
Copy Markdown

As per #559

@FriedrichFroebel

Copy link
Copy Markdown

Wouldn'it it be nicer to have an actual fix instead?

@JasonGross

Copy link
Copy Markdown
Author

It would, but I don't have time to prepare an actual fix right now, and this is an easy patch to revert when a fix lands, and I don't think breaking pip's solver on this package while we wait for a fix(/wait to find time to fix it) is a good idea. Note that I didn't mark this PR as fixing the corresponding issue, and I don't think it makes sense to close that issue until a proper fix lands.

@XxSonicGhostxX XxSonicGhostxX left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want everything in my env to be normal not sure what would implement that but that's my requested change

@JasonGross

Copy link
Copy Markdown
Author

Wouldn'it it be nicer to have an actual fix instead?

It seems there are a bunch of fixes for this in the wild that have not been turned into PRs, e.g., RobertDeibel#2, lukashof@9eddaba, lucaslrodri@860e4a5

@lukashof

lukashof commented Apr 3, 2024

Copy link
Copy Markdown

I created a PR #602. But I think it's been a while since something got merged, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants