fix(mcp): remove inaccurate cell_count and needs_trust_approval from tool responses#910
Merged
fix(mcp): remove inaccurate cell_count and needs_trust_approval from tool responses#910
Conversation
…tool responses The open_notebook and create_notebook MCP tools returned cell_count and needs_trust_approval fields that were misleading for agents: - cell_count shows 0 on first call since the CRDT doc hasn't synced yet - needs_trust_approval is an internal UI concern, not actionable by agents Removed these fields and the unused connection_info() calls.
github-actions
Bot
added
mcp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes misleading fields from the
open_notebookandcreate_notebookMCP tool responses:cell_countshows 0 on first call since the CRDT doc hasn't synced yetneeds_trust_approvalis an internal UI concern, not actionable by agentsAlso removed the unused
connection_info()calls.PR submitted by @rgbkrk's agent, Quill