Adapt cmdline assert for nushell/nushell#15881#57
Merged
Conversation
Script Analysis
Security Review
Optimization Suggestions
Overall Quality: 4 (The change is solid but could be slightly more robust with path expansion) |
This was referenced Jun 4, 2025
sholderbach
pushed a commit
to nushell/nushell
that referenced
this pull request
Jun 4, 2025
# Description This PR fixes regressions introduced by #15881. # User-Facing Changes None. # Tests + Formatting See nushell/integrations#57. # After Submitting None.
Contributor
Author
|
Are these workflows running against |
Contributor
They run against the latest nightly builds, and It's scheduled to run every morning, I have just started the nightly build workflow manually |
kumarUjjawal
pushed a commit
to kumarUjjawal/nushell
that referenced
this pull request
Jun 5, 2025
# Description This PR fixes regressions introduced by nushell#15881. # User-Facing Changes None. # Tests + Formatting See nushell/integrations#57. # After Submitting None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to nushell/nushell#15881.
Related to nushell/nushell#15889.