#4299: upgrade go-did to v0.21.0 for VP-JWT iss claim fix#4300
Merged
Conversation
Encodes the presentation holder as the JWT `iss` claim and drops the non-standard `vp.holder` field, per go-did#148. The existing parser already treats `iss` as the canonical holder, so no source changes are needed. Adds a regression test asserting the holder is carried in `iss` and that `vp.holder` is no longer emitted. Assisted by AI
reinkrul
requested review from
gerardsn,
stevenvegt and
woutslakhorst
as code owners
stevenvegt
approved these changes
Jun 2, 2026
Contributor
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4299.
Bumps
github.com/nuts-foundation/go-didfrom v0.20.0 to v0.21.0, pulling in go-did#148.What changed
issclaim and no longer emit the non-standardvp.holderfield, aligning with W3C VC Data Model v1.1.vcr/holderasserting the holder lands inissandvp.holderis gone.Why
AORTA testing rejected our VP-JWTs as non-compliant: the
issclaim was missing and aholderfield appeared inside the VP object. Root cause was in go-did.Scope
Dependency bump + regression test only — no production source changes. The existing parser already treats
issas the canonical holder. Fullvcr/...andauth/...suites pass.Assisted by AI