Skip to content

fix(vcr/verifier): handle unparseable issuer DID instead of panicking #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reinkrul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(vcr/verifier): handle unparseable issuer DID instead of panicking #4302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vcr/verifier/verifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,10 @@ func (v verifier) Verify(credentialToVerify vc.VerifiableCredential, allowUntrus

// Check signature
if checkSignature {
issuerDID, _ := did.ParseDID(credentialToVerify.Issuer.String())
issuerDID, err := did.ParseDID(credentialToVerify.Issuer.String())
if err != nil {
return fmt.Errorf("could not parse issuer DID: %w", err)
}
metadata := resolver.ResolveMetadata{ResolveTime: validAt, AllowDeactivated: false}
rawJwt := credentialToVerify.Raw()
if rawJwt != "" {
Expand Down
19 changes: 19 additions & 0 deletions vcr/verifier/verifier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,25 @@ func TestVerifier_Verify(t *testing.T) {
})
})

t.Run("fails (instead of panicking) when issuer DID is unparseable", func(t *testing.T) {
// Regression test for #4235: an unparseable issuer DID (e.g. a did:x509 with trailing
// unsupported fields) must result in a validation error, not a nil-pointer panic.
ctx := newMockContext(t)
credID := ssi.MustParseURI("did:web:example.com#1")
cred := vc.VerifiableCredential{
Context: []ssi.URI{vc.VCContextV1URI()},
Type: []ssi.URI{vc.VerifiableCredentialTypeV1URI(), ssi.MustParseURI("ExampleCredential")},
ID: &credID,
Issuer: ssi.MustParseURI("did:x509:0:sha256:abc::san:otherName:1.2.3.4#extra"),
IssuanceDate: time.Now().Add(-time.Hour),
}
ctx.store.EXPECT().GetRevocations(credID).Return(nil, ErrNotFound)

validationErr := ctx.verifier.Verify(cred, true, true, nil)

assert.ErrorContains(t, validationErr, "could not parse issuer DID")
})

t.Run("invalid when revoked", func(t *testing.T) {
vc := testCredential(t)
ctx := newMockContext(t)
Expand Down
Loading