fix(security): allow disabling proxy signing with security: false#789
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds a Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
security: false
🔗 Linked issue
Resolves #783
❓ Type of change
📚 Description
The proxy page token is injected into the SSR payload on every request, so the response hash changes each time. This breaks computing a stable
etag, and the only way to avoid it was to leave the proxy secret unset (not possible in dev, where it auto-generates).securitynow acceptsfalse. When set, the module resolves no secret, auto-generates nothing into.env, skips the page token plugin, andwithSigningpasses proxy requests through without verification. This is a clean, single-flag opt-out of all proxy security. Documented in the first-party guide.