Skip to content

fix(docs): rename framework SEO suffix to avoid redeclaration#6607

Closed
ReCoN-96 wants to merge 2 commits into
nuxt:v4from
ReCoN-96:fix/docs-slug-framework-redeclaration
Closed

fix(docs): rename framework SEO suffix to avoid redeclaration#6607
ReCoN-96 wants to merge 2 commits into
nuxt:v4from
ReCoN-96:fix/docs-slug-framework-redeclaration

Conversation

@ReCoN-96

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Fixes a build error introduced in docs: improve SEO metadata.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The recent SEO metadata update added a local const framework in docs/app/pages/docs/[...slug].vue to append a " for Vue" suffix to page titles. That name was already taken by the framework ref from useFrameworks(), causing a Vite parse error:

The SEO metadata change introduced a local `framework` constant that
shadowed the ref from `useFrameworks()`, breaking the docs dev server.
@ReCoN-96 ReCoN-96 requested a review from benjamincanac as a code owner June 19, 2026 07:49
@github-actions github-actions Bot added the v4 #4488 label Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 36843771-442c-49b7-a4ac-cfbe89fab4b6

📥 Commits

Reviewing files that changed from the base of the PR and between ed4712c and 2f1d112.

📒 Files selected for processing (1)
  • docs/app/pages/docs/[...slug].vue

📝 Walkthrough

Walkthrough

The docs slug page SEO metadata logic is updated so that a frameworkSuffix string (e.g., " for Vue") is conditionally appended to the titleTemplate and ogTitle fields in useSeoMeta. The suffix is only added when the page title does not already contain "Vue", determined by checking prefix and whether page.value?.framework === 'vue'. This replaces the previous framework variable. The description constant assignment is also moved into the same block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: renaming a framework variable to fix a redeclaration error in the docs SEO metadata.
Description check ✅ Passed The description clearly explains the bug being fixed: a variable name conflict between a local const and a ref from useFrameworks() that caused a Vite parse error.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benjamincanac

Copy link
Copy Markdown
Member

Closing as it has already been solved in ed4712c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants