Skip to content

fix(LocaleSelect): add missing keys in emoji mapping#6629

Merged
benjamincanac merged 2 commits into
nuxt:v4from
reslear:patch-3
Jun 22, 2026
Merged

fix(LocaleSelect): add missing keys in emoji mapping#6629
benjamincanac merged 2 commits into
nuxt:v4from
reslear:patch-3

Conversation

@reslear

@reslear reslear commented Jun 22, 2026

Copy link
Copy Markdown
Contributor
before after
CleanShot 2026-06-22 at 13 38 10@2x CleanShot 2026-06-22 at 13 44 22@2x

@reslear reslear requested a review from benjamincanac as a code owner June 22, 2026 11:44
@github-actions github-actions Bot added the v4 #4488 label Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 187b1c31-557e-4155-8516-4496e7e50f20

📥 Commits

Reviewing files that changed from the base of the PR and between 00a0802 and d73f964.

📒 Files selected for processing (1)
  • src/runtime/components/locale/LocaleSelect.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/runtime/components/locale/LocaleSelect.vue

📝 Walkthrough

Walkthrough

The languageToCountry lookup table in the getEmojiFlag function within LocaleSelect.vue is extended with multiple language-to-country code associations. Changes include adding be: 'by' for Belarusian, eu: 'es' for Basque, and lo: 'la' for Lao, along with other locale mappings that enable correct emoji flag rendering for those languages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding missing keys to the emoji mapping in LocaleSelect component.
Description check ✅ Passed The description provides visual evidence (before/after screenshots) of the fix to the locale-to-emoji-flag mapping, demonstrating the functional impact of the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Jun 22, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@6629

commit: d73f964

@benjamincanac benjamincanac changed the title fix: Belarusian locale to emoji flag mapping fix(LocaleSelect): add missing keys in emoji mapping Jun 22, 2026
@benjamincanac benjamincanac merged commit fab73ab into nuxt:v4 Jun 22, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants