Re-export schema types from nvisy-engine - #337
Merged
Merged
Conversation
Fold nvisy_schema's modules into nvisy-engine's public surface so SDK consumers depending only on nvisy-engine can name every type its public API accepts or returns: - Widen schema's `entity`, `modality`, and `primitive` modules to cover the full elide-core slice callers reach through Entity<M>, RecognizedGroup variants, and Scope. - Add `FormatRegistry` at engine's root (leaks through Engine::formats). - Drop elide-bento's root re-exports of BentoNer/BentoOcr; update the two engine consumers to use the module paths. - Unify module-level doc summaries across schema + engine so the rendered first line is a consistent noun phrase. Override the `policy` re-export's docstring so it no longer picks up the target crate's H1. - Convert all remaining inline rustdoc `[text](path)` links to reference form. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvisy_schema's modules intonvisy-engine's public surface so SDK consumers depending only onnvisy-enginecan name every type its public API accepts or returns (Entity, Modality markers, Label, Scope, FormatRegistry, etc.).schema::entity,schema::modality,schema::primitiveto cover the full elide-core slice callers reach throughEntity<M>,RecognizedGroupvariants, andScope.elide-bento's root re-exports ofBentoNer/BentoOcr; update the two engine consumers to use the module paths.[text](path)links to reference form.Test plan
cargo check --workspace --all-featurescargo clippy --workspace --all-features --all-targets(no warnings)cargo test --workspace --all-featuresRUSTDOCFLAGS="--cfg docsrs -D warnings" cargo +nightly doc --workspace --all-features --no-depscargo deny check🤖 Generated with Claude Code