replace hexbin grid origin offset with rounding towards the center#2367
Closed
Fil wants to merge 5 commits intofil/refresh-snapshotsfrom
Closed
replace hexbin grid origin offset with rounding towards the center#2367Fil wants to merge 5 commits intofil/refresh-snapshotsfrom
Fil wants to merge 5 commits intofil/refresh-snapshotsfrom
Conversation
…ndefined (older browser), or <= 1 (actual low-res screen)
…anslation we apply on lower DPI screens
The hexbin transform used a hardcoded ox=0.5 to avoid Math.round(.5) ties on the right edge, but this caused floating bins on the left odd rows.
Closed
Fil
force-pushed
the
fil/refresh-snapshots
branch
from
7384d08 to
dae56cb
Compare
Member
|
Is this the same as #2377? Ref. https://observablehq.com/@observablehq/hexbin-offset-drama Maybe we can just change the origin of the hex grid so that it’s less likely that hexagons are cut in half along the left and right edges? Like just shift the grid by a quarter hexagon width? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hexbin transform used a hardcoded ox=0.5 to avoid Math.round(.5) ties on the right edge, but this caused floating bins on the left odd rows.
closes an issue mentioned in #2365