Skip to content

fit tip#2388

Draft
Fil wants to merge 1 commit intomainfrom
fil/fix-2011
Draft

fit tip#2388
Fil wants to merge 1 commit intomainfrom
fil/fix-2011

Conversation

@Fil
Copy link
Copy Markdown
Contributor

@Fil Fil commented Mar 18, 2026

fixes #2011

saving as draft as I don't think we have enough test coverage

@mbostock
Copy link
Copy Markdown
Member

mbostock commented Apr 8, 2026

I made a notebook to explore the logic: https://observablehq.com/d/248a1e32c96c45db

The fitLeft check doesn’t strictly mean “the tip would fit using the left anchor” because the tip could still be outside the vertical bounds. It tells you when any of the left-anchored tips cross the right edge of the chart area.

Also I think the pointerSize is effectively doubled when using a corner anchor, which doesn’t seem right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the default tip sometimes goes in the wrong direction

2 participants