fix: pass cwd to npmRunPathEnv to prevent PATH hijack @W-23797722@ - #1386
Open
WillieRuemmele wants to merge 1 commit into
Open
fix: pass cwd to npmRunPathEnv to prevent PATH hijack @W-23797722@#1386WillieRuemmele wants to merge 1 commit into
WillieRuemmele wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cwdtonpmRunPathEnv()insrc/spawn.tsso the child process PATH is built relative to the plugin install directory, notprocess.cwd()node_modules/.bin/nodein the repository from being resolved before the trusted Node runtime during JIT plugin installationWork Item
@W-23797722@: [Bug Bounty / H1] SF CLI - Automatic JIT plugin installation executes repository-local
nodebefore the trusted runtimeTest plan
node_modules/.bin/nodeexecutablesf dev audit messages) and verify the malicious node is NOT executed