fix(core): track STATUS_TRANSITION_VIOLATION status per connector#131
Merged
Conversation
The rule validated connector status transitions against a single previous status shared across all connectors, so on a multi-connector station an interleaved notification from a different connector (connector 1 going Available while connector 2 goes Finishing) was reported as an invalid transition. Status is now tracked per connectorId (connectorId 0, the charge point as a whole, forms its own series), and each transition is validated only within one connector's series. Genuine per-connector violations are still detected, so the scenario corpus and conformance contract are unchanged. Adds three regression tests. Reported by shiv3 from the ocpp-cp-simulator integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
STATUS_TRANSITION_VIOLATIONfalse positives shiv3 reported (#127 sibling).The rule validated connector status transitions against a single previous status shared across all connectors, so on a multi-connector station an interleaved notification from a different connector (connector 1 going
Availablewhile connector 2 goesFinishing) was reported as an invalid transition.Change
Status is now tracked per
connectorId(connectorId 0, the charge point as a whole, forms its own series), and each transition is validated only within one connector's series.Safety
Genuine per-connector violations are still detected: the status-transition-violation scenario still yields
STATUS_TRANSITION_VIOLATIONand the 15-scenario conformance contract is unchanged. Three regression tests cover cross-connector interleaving that only looks invalid globally, a genuine per-connector violation caught amid interleaving, and connectorId 0 as its own series. Full gate green: lint, typecheck, 518 tests, build. Patch changeset included.Reported by shiv3.
Closes #128