Draft
Conversation
To stay consistent with the implementation of Material Symbols library.
- From FA an OI icons to new Material Symbols using `oi` prefix class Controler classes use `oi-`prefix, eg. `oi-lg`, `oi-rotate-90`, etc. - This commit extends our OI library to cover icons that are not handled by Material Symbols. - introduces RTL support for icons - fa-[6-10]x was defined in html_editor but used in several modules. This commit regroup them in webclient icons.scss to be more generic.
This commit applies the new icon implementation globally, replacing all "classic" occurrences of icons. For example: From `class="oi oi-fw oi-arrow-left"` or `class="fa fa-fw fa-arrow-left"` To `class="oi oi-fw" data-icon="west"`
This commit covers all CSS and SCSS necessary changes for the new icon implementation.
*: mass_mailing, website, website_hr_recruitment
Brieuc-brd
force-pushed
the
master-fa-ms
branch
6 times, most recently
from
eafe737 to
2e50669
Compare
stefanorigano
force-pushed
the
master-fa-ms
branch
from
ea7a322 to
7282da3
Compare
Brieuc-brd
force-pushed
the
master-fa-ms
branch
6 times, most recently
from
cbb9c6c to
0bfad61
Compare
stefanorigano
force-pushed
the
master-fa-ms
branch
3 times, most recently
from
185f96e to
8e057b1
Compare
Brieuc-brd
force-pushed
the
master-fa-ms
branch
2 times, most recently
from
4cb5e6e to
5e4331f
Compare
stefanorigano
force-pushed
the
master-fa-ms
branch
from
cd6fb76 to
d1b05a9
Compare
Brieuc-brd
force-pushed
the
master-fa-ms
branch
from
5a229d9 to
de6d5ec
Compare
stefanorigano
force-pushed
the
master-fa-ms
branch
from
de6d5ec to
585bdb9
Compare
Brieuc-brd
force-pushed
the
master-fa-ms
branch
8 times, most recently
from
7df28c5 to
2f5066e
Compare
Brieuc-brd
force-pushed
the
master-fa-ms
branch
from
2f5066e to
5d081d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, a lot of runbot errors appeared dur to the new icons.
task-6075556