Open
Conversation
…e module installation.
vava-odoo
reviewed
Jun 10, 2025
estate/demo/estate_property.xml
Outdated
| <field name="state">new</field> | ||
| <field name="description">A nice and big villa</field> | ||
| <field name="postcode">12345</field> | ||
| <field name="date_availability">2020-02-02</field> |
There was a problem hiding this comment.
This should preferably be relative to the date of install (see codebase for examples)
estate/demo/estate_property.xml
Outdated
| <odoo> | ||
| <record id="estate_property_1" model="estate.property"> | ||
| <field name="name">Big Villa</field> | ||
| <field name="state">new</field> |
There was a problem hiding this comment.
As it is the default value, you're not forced to provide it
Suggested change
| <field name="state">new</field> |
estate/demo/estate_property.xml
Outdated
| <field name="postcode">54321</field> | ||
| <field name="date_availability">1970-01-01</field> | ||
| <field name="expected_price">100000</field> | ||
| <field name="selling_price">120000</field> |
There was a problem hiding this comment.
Why a selling_price if the state is cancelled?
| <function model="estate.property.offer" name="action_offer_refuse" eval="[ref('estate_property_offer_1')]"/> | ||
| <function model="estate.property.offer" name="action_offer_refuse" eval="[ref('estate_property_offer_2')]"/> | ||
| <function model="estate.property.offer" name="action_offer_accept" eval="[ref('estate_property_offer_3')]"/> | ||
| </odoo> No newline at end of file |
…d/cancelled property. -Added check to raise an error if a property is sold without any offer accepted. -Created tests cases to verify total area calculation, verify action_property_sold, and verify offer creation for sold property. -Added missing new lines in some files.
vava-odoo
reviewed
Jun 10, 2025
estate/tests/test_estate_property.py
Outdated
|
|
||
| cls.properties = cls.env['estate.property'].create([{'name': 'test_house'}]) | ||
| cls.partner = cls.env['res.partner'].create([{ | ||
| 'id': 'test_partner', |
There was a problem hiding this comment.
id?! don't touch this 😄
Suggested change
| 'id': 'test_partner', |
estate/tests/test_estate_property.py
Outdated
Comment on lines
+18
to
+26
| 'company_name': 'test_company', | ||
| 'street': 'test_street', | ||
| 'city': 'test_city', | ||
| 'zip': '12345', | ||
| 'country_id': cls.env.ref('base.us').id, | ||
| 'state_id': cls.env.ref('base.state_us_39').id, | ||
| 'phone': '+1 555-555-5555', | ||
| 'email': 'test@testing.example.com', | ||
| 'tz': 'Europe/Brussels', |
There was a problem hiding this comment.
Do you need all this? I bet a name is sufficient for your case
Suggested change
| 'company_name': 'test_company', | |
| 'street': 'test_street', | |
| 'city': 'test_city', | |
| 'zip': '12345', | |
| 'country_id': cls.env.ref('base.us').id, | |
| 'state_id': cls.env.ref('base.state_us_39').id, | |
| 'phone': '+1 555-555-5555', | |
| 'email': 'test@testing.example.com', | |
| 'tz': 'Europe/Brussels', |
estate/tests/test_estate_property.py
Outdated
| # add env on cls and many other things | ||
| super().setUpClass() | ||
|
|
||
| cls.properties = cls.env['estate.property'].create([{'name': 'test_house'}]) |
There was a problem hiding this comment.
Plural is misleading
Suggested change
| cls.properties = cls.env['estate.property'].create([{'name': 'test_house'}]) | |
| cls.property = cls.env['estate.property'].create([{'name': 'test_house'}]) |
estate/tests/test_estate_property.py
Outdated
Comment on lines
+36
to
+38
| self.assertRecordValues(self.properties, [ | ||
| {'total_area': 35}, | ||
| ]) |
There was a problem hiding this comment.
assertEqual if only one value to check, no?
estate/tests/test_estate_property.py
Outdated
Comment on lines
+59
to
+60
| self.properties.offer_ids.action_offer_accept() | ||
| self.properties.action_property_sold() |
There was a problem hiding this comment.
Not related to tests, but I have the feeling that action_offer_accept should mark the property as sold, so why do you need the call to action_property_sold?
Author
There was a problem hiding this comment.
In the estate tutorial accepting the offer and selling the property are two different states.
After accepting an offer you can still cancel the property, not sell it.
estate/tests/test_estate_property.py
Outdated
| def test_action_sell_with_accepted_offer(self): | ||
| """Test that everything behaves like it should when selling a valid property.""" | ||
|
|
||
| self.properties.offer_ids.create({ |
There was a problem hiding this comment.
Weird way to create an offer. Either use self.env['property.offer'].create(...), either create it while editing the field offer_ids with Command
Arbaaz-Khan-Tech
added a commit
that referenced
this pull request
Apr 9, 2026
I-ntroduce the necessary UI views to display the estate model records in the Odoo interface. -Includes XML files . The new view files are registered in the module's manifest to ensure they are loaded correctly. Chapter #5
Arbaaz-Khan-Tech
added a commit
that referenced
this pull request
Apr 9, 2026
- Introduce active and state fields for properties to manage their lifecycle and visibility. - Add a custom logo to the dashboard . - Refactor existing code to adhere to project coding guidelines. - Incorporate feedback from previous reviews . Chapter #5
Arbaaz-Khan-Tech
added a commit
that referenced
this pull request
Apr 9, 2026
- Removed unused imports from __manifest__.py to resolve build errors. - Compressed Real_Estate_Logo.jpg to reduce its size below 100KB, addressing a build error related to image size limits. Chapter #5
Arbaaz-Khan-Tech
added a commit
that referenced
this pull request
Apr 10, 2026
- The 'postcode' field has been changed to a Char type to accommodate various international postal code formats. - The 'living_area' field has been updated to a Float type to allow for more precise measurements of living space in square meters (sqm). Chapter #5
Arbaaz-Khan-Tech
added a commit
that referenced
this pull request
Apr 10, 2026
- The 'garden_area' field has been updated to a Float type to allow for more precise measurements of living space in square meters (sqm). Chapter #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.