Closed
Conversation
Collaborator
|
|
mcsi-odoo
force-pushed
the
19.0-general-settings-offline-mode-mcsi
branch
from
c7eca4b to
ddd80f5
Compare
auva-odoo
reviewed
Apr 10, 2026
Contributor
auva-odoo
left a comment
auva-odoo
left a comment
There was a problem hiding this comment.
Hi @mcsi-odoo, sorry for my probably stupid question on this PR. It might be simpler to discuss this IRL, let me know what you think!
mcsi-odoo
force-pushed
the
19.0-general-settings-offline-mode-mcsi
branch
from
ddd80f5 to
fd415d4
Compare
Contributor
Author
|
Hey @auva-odoo , some small updates made, as discussed. See what you think. |
auva-odoo
reviewed
Apr 15, 2026
auva-odoo
reviewed
Apr 15, 2026
Contributor
auva-odoo
left a comment
auva-odoo
left a comment
There was a problem hiding this comment.
Thank you for taking my feedback into consideration @mcsi-odoo. This LGTM! 🙏
@robodoo delegate+
task-6080512
mcsi-odoo
force-pushed
the
19.0-general-settings-offline-mode-mcsi
branch
from
fd415d4 to
5488080
Compare
Contributor
Author
|
@robodoo r+ |
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task-6080512