[IMP] estate: added auto fields and smart defaults by patsh-odoo · Pull Request #1224 · odoo/tutorials

patsh-odoo · 2026-04-03T10:38:09Z

[IMP] estate: added data validation rules for prices and names

Added rules to ensure that all prices entered in the system are valid and
meaningful, such as making sure property prices and offer amounts are
greater than zero. Also ensured that property types and tags cannot have
duplicate names. Additionally, added a rule to prevent accepting offers
that are significantly lower than the expected property price.

These changes help maintain accurate and reliable data by preventing incorrect
or unrealistic entries. This improves overall data quality, avoids confusion
caused by duplicate names, and ensures that business decisions (like accepting
offers) follow sensible limits.

robodoo · 2026-04-03T10:38:12Z

bit-odoo

Hello @patsh-odoo

Can you please follow the git guidelines?
https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html

And can you please use ruff for proper formatting?

You can check this style error - https://runbot.odoo.com/runbot/batch/2459862/build/106615533

Thanks

bit-odoo · 2026-04-08T07:13:00Z

estate/models/estate_property.py

+from odoo import models, fields
+
+
+class estate(models.Model):


The class name is in Pascal case. Please read the Python coding guidelines.
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#python

bit-odoo · 2026-04-08T07:13:47Z

estate/security/ir.model.access.csv

+estate_property_ac1,basic_access,model_estate_property,base.group_user,1,1,1,1
+estate_property_type_ac1,basic_access_type,model_estate_property_type,base.group_user,1,1,1,1
+estate_property_tag_ac1,basic_access_tag,model_estate_property_tag,base.group_user,1,1,1,1
+estate_property_offer_ac1,basic_access_offer,model_estate_property_offer,base.group_user,1,1,1,1


Should be one empty line at the end of the file.

bit-odoo · 2026-04-08T07:13:56Z

estate/views/estate_menus.xml

+            <menuitem id="estate_property_menu_action_property_tag"  action="estate_property_tag_action1"/>
+        </menuitem>
+    </menuitem>
+</odoo>


Should be one empty line at the end of the file.

bit-odoo · 2026-04-08T07:14:03Z

estate/views/estate_property_offer_views.xml

+    </record>
+
+
+</odoo>


Should be one empty line at the end of the file.

bit-odoo · 2026-04-08T07:14:14Z

estate/views/estate_property_offer_views.xml

+            </form>
+        </field>
+    </record>
+


unneccary space.

bit-odoo · 2026-04-08T07:14:22Z

estate/views/estate_property_tag_views.xml

+        </field>
+    </record>
+
+</odoo>


Should be one empty line at the end of the file.

bit-odoo · 2026-04-08T07:14:37Z

estate/views/estate_property_tag_views.xml

+        <field name="arch" type="xml">
+            <form>
+                <div class="oe_title">
+                <h1><field name="name"/></h1>


indentation issue.

bit-odoo · 2026-04-08T07:14:49Z

estate/views/estate_property_type_views.xml

+        </field>
+    </record>
+
+</odoo>


Should be one empty line at the end of the file.

bit-odoo · 2026-04-08T07:16:22Z

estate/__manifest__.py

+    'name': "estate",
+    'depends': ['base'],
+    'application': True,
+    'data': ['security/ir.model.access.csv', 'views/estate_property_type_views.xml', 'views/estate_property_tag_views.xml', 'views/estate_property_offer_views.xml', 'views/estate_property_views.xml', 'views/estate_menus.xml']


Suggested change

'data': ['security/ir.model.access.csv', 'views/estate_property_type_views.xml', 'views/estate_property_tag_views.xml', 'views/estate_property_offer_views.xml', 'views/estate_property_views.xml', 'views/estate_menus.xml']

'data': [

'security/ir.model.access.csv',

'views/estate_property_type_views.xml',

'views/estate_property_tag_views.xml',

'views/estate_property_offer_views.xml',

'views/estate_property_views.xml',

'views/estate_menus.xml'

],

This commit introduces the new estate module, which includes features to define and organize property listings. Users can now record essential details such as names, postcodes, and descriptions, alongside specific features like the number of bedrooms, living area size, and garden details. It also includes tracking for pricing, availability dates, and the current status of the property (such as "New", "Offer Received", or "Sold"). These properties can be viewed and managed through simple, easy-to-use lists and detailed forms. The need for this module stems from the requirement to make property management easy and centralized. By moving away from manual tracking, this update enables the team to see all property details at a glance in a list view and manage specific information within a single form. This ensures that every listing is accounted for and the sales process is organized and easy to follow for all users. chapter: 1,2,3,4,5

Added custom search, form, and list views for properties in the estate module. These changes were made because the default views did not organize property information clearly. The custom views group related fields like title, postcode, expected price, bedrooms, living area, and facades together, making it easier to read and manage property details. The search view includes filters to show only available properties and allows users to group properties by attributes like postcode. This helps users quickly find, sort, and compare properties in a structured and organized way. chapter: 6(Basic Views)

Added fields for buyer, salesperson, and related property offers, as well as property tags (like “cozy”). Custom views for these fields were also created. These changes make it easier to see and manage all key details of a property in one place. Users can quickly identify the buyer and salesperson, check associated offers, and view property features at a glance. Tags and custom views help organize the information and make it more accessible.

Added total area and best offer calculation, linked offer validity and deadline dates setting any one will automatically set another, and default values for garden details will be automatically filled when garden is selected. These changes make data entry easier and reduce manual work. The total area and best offer are calculated automatically, so users don’t need to compute them. Offer validity and deadline are connected, meaning entering one will automatically fill the other, avoiding confusion. When a garden is selected, related fields like area and orientation are pre-filled with default values, helping users enter information faster and more consistently. chapter: 8(Computed Fields And Onchanges)

User can now click a Sold or Cancel button to change a property’s status instantly. The system also protects your data by making sure a house that is already sold cannot be canceled, and a canceled house cannot be sold. Additionally, individual offers now have Accept and Refuse buttons. When you accept an offer, the system automatically fills in the buyer's name and the final price on the main page, ensuring that only one offer can be finalized for a property. These buttons make user's work faster because the system does the typing for user, user don't have to copy and paste the buyer's name or the price. The rules keep records correct by making sure user don't click the wrong button by accident. chapter: 9(Ready For Some Action?)

Added rules to ensure that all prices entered in the system are valid and meaningful, such as making sure property prices and offer amounts are greater than zero. Also ensured that property types and tags cannot have duplicate names. Additionally, added a rule to prevent accepting offers that are significantly lower than the expected property price. These changes help maintain accurate and reliable data by preventing incorrect or unrealistic entries. This improves overall data quality, avoids confusion caused by duplicate names, and ensures that business decisions (like accepting offers) follow sensible limits.

bit-odoo reviewed Apr 8, 2026

View reviewed changes

patsh-odoo changed the title ~~[ADD] estate - Added menus and security rules~~ [ADD] estate: added computed fields and onchange method Apr 8, 2026

patsh-odoo force-pushed the 19.0-tutorials-patsh branch 4 times, most recently from db4a40c to fba0a1d Compare April 9, 2026 18:37

patsh-odoo added 2 commits April 10, 2026 00:13

patsh-odoo force-pushed the 19.0-tutorials-patsh branch from fba0a1d to 3e66a6e Compare April 9, 2026 19:03

patsh-odoo changed the title ~~[ADD] estate: added computed fields and onchange method~~ [IMP] estate: added auto fields and smart defaults Apr 9, 2026

patsh-odoo force-pushed the 19.0-tutorials-patsh branch from 8becf43 to 654f91d Compare April 10, 2026 13:06

patsh-odoo added 3 commits April 10, 2026 18:48

patsh-odoo force-pushed the 19.0-tutorials-patsh branch from 654f91d to ffe3c75 Compare April 10, 2026 13:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] estate: added auto fields and smart defaults#1224

[IMP] estate: added auto fields and smart defaults#1224
patsh-odoo wants to merge 6 commits intoodoo:19.0from
odoo-dev:19.0-tutorials-patsh

patsh-odoo commented Apr 3, 2026 •

edited

Loading

Uh oh!

robodoo commented Apr 3, 2026

Uh oh!

bit-odoo left a comment

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

bit-odoo Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		</record>


		</odoo> No newline at end of file

Conversation

patsh-odoo commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Apr 3, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

patsh-odoo commented Apr 3, 2026 •

edited

Loading