Skip to content

Support strings containing "from now"#22

Open
j-sv wants to merge 1 commit into
olebedev:masterfrom
j-sv:from-now
Open

Support strings containing "from now"#22
j-sv wants to merge 1 commit into
olebedev:masterfrom
j-sv:from-now

Conversation

@j-sv

@j-sv j-sv commented Oct 27, 2019

Copy link
Copy Markdown

Adds support for one of the examples listed here.

@olebedev olebedev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested patch changes expected behavior fro deadlines from
strict (within|in) <point in time> for (within|in)? <point in time> (from now)?. This means that even a simple point in time will be treated as a deadline. I am not sure about the approach and still think that keep the rule as narrow as possible could save us from the unexpected indeterministic behavior of the parser.

I suggest implementing a rule like(simplified regexp):

((within|in)\s<point in time>)|(<point in time>\sfrom\now)

so it will be a narrower OR.

@j-sv

j-sv commented Oct 29, 2019

Copy link
Copy Markdown
Author

You're right, I hadn't considered that. I'll update it as you suggest.

@olebedev

Copy link
Copy Markdown
Owner

Hey @j-sv, just a friendly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants