Conversation
move license to the right page footer
Happened automatically on save.
|
Done. Won't edit this branch anymore until it's been reviewed ✅ |
|
This looks amazing! Exactly what I wanted. Approved from here. |
K-Beicher
left a comment
K-Beicher
left a comment
There was a problem hiding this comment.
Brilliant, we can remove the files we talked about yesterday and then feel free to merge!
| page-footer: | ||
| center: | ||
| center: "{height='40px'} {height='40px'} {height='40px'} {height='40px'} {height='40px'} {height='40px'}" | ||
| right: |
There was a problem hiding this comment.
Rather than require it by default here for ALL websites to have the footer on every single page, can we instead put it this page-footer for the individual websites we want this on? For example, adding this to the footer to the theme means that every page of the DMP (and there are many) will have this footer, even when we make this as a PDF and upload to Zenodo. Which is excessive. @danielibsen
There was a problem hiding this comment.
Another example, when we generate the website for the documentation of the data, every page will have this footer, which is a lot of noise to each page of a website. Websites should be clean and to the point, without too much extra stuff distracting from the content.
There was a problem hiding this comment.
That's a good point, @lwjohnst86. Should I move this to the _quarto.yml? And potentially add to the index.qmd how to add this footer on a website?
There was a problem hiding this comment.
Yea, we could also include it so that the footer points to a page with a list of collaborating partners, e.g. on the DMP, it could be an appendix in the book.
There was a problem hiding this comment.
Do you mean showing the logos still and then if someone clicks on them, they'll be referred to the DMP?
There was a problem hiding this comment.
No, more like having a "partners" page (maybe on the main website), and other websites like the DMP would have a footer called "Partners" or something that links to that main page.
There was a problem hiding this comment.
@lwjohnst86 So, instead of showing the logos, a link to a collaborators/partners page? Should we include this in the extension.yml or still move it to quarto.yml, so it isn't the default for onlimit websites?
There was a problem hiding this comment.
Re the showing on all pages or not. I like that it is there on all pages as a standard. This is one thing the individual institutions like very much. So for now, I think we go with the logos on everything. Under "about" we do mention the partners. I dont think we need much more than that. So all good from my side.
There was a problem hiding this comment.
@danielibsen just to clarify, they like that for the main website or for ALL websites? And what about my mention of how that fits with PDFs? (and thinking about this more, book-style websites won't use this page-footer anyway, since it is under website: header, not book:, so maybe this doesn't actually matter too much). What about for the metadata documentation websites? Is that the same things? or when we want to render them as either website or book/PDF? How does that fit?
4 participants
Description
This adds the logos of collaborators to the footer of the theme (as described by @K-Beicher).
I've added some custom css to create the proper spacing for and between the logos.
Closes #5
It looks like this:
And wraps nicely on smaller screens: