sedimentation removal dynamic (for 0-d environments)#1722
Open
slayoo wants to merge 24 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
+ Coverage 86.99% 87.05% +0.05%
==========================================
Files 418 420 +2
Lines 10692 10739 +47
==========================================
+ Hits 9302 9349 +47
Misses 1390 1390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slayoo
changed the title
|
Stale pull request message |
…ew dynamic to SedimentationRemoval0D to hint it can also be used with Box environment
slayoo
commented
May 30, 2026
| builder.request_attribute("relative fall velocity") | ||
| assert builder.particulator.environment.mesh.n_dims == 0 | ||
| self.particulator = builder.particulator | ||
| self.length_scale = np.cbrt(self.particulator.environment.mesh.dv) |
Member
Author
There was a problem hiding this comment.
@tluettm, in the Parcel environment, the dv is time-dependent, while here we use it in the register() method, hence only once at the start of the simulation. It is likely OK given this is just to derive a length scale, but I winder if not to move it to __call__ to avoid misleading location of this logic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.