fix(release): restore go.mod tidy state#521
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #520
What went wrong
The release workflow failed in GoReleaser's
Build (snapshot, no publish)step because itsmake tidybefore-hook changedgo.mod.internal/agents/agents.godirectly importsgithub.com/gobwas/glob, but the dependency was still marked indirect.Narrow fix
Move the existing
github.com/gobwas/glob v0.2.3requirement from the indirect block to the direct block. No dependency version, checksum, or application code changes.Empirical verification
make tidyproduced exactly this one dependency reclassification and exited nonzero.go mod tidyagain and confirmed SHA-256 hashes of bothgo.modandgo.sumwere unchanged before/after.make tidypasses againstHEAD.make lintpasses with zero issues.make testpasses.make buildpasses.After merge, the final acceptance criterion is a successful release workflow whose GoReleaser snapshot step gets past the tidy before-hook.