Skip to content

feat: Add VMLens Tests#1661

Merged
toddbaert merged 16 commits into
open-feature:mainfrom
chrfwow:add-vmlens
Feb 18, 2026
Merged

feat: Add VMLens Tests#1661
toddbaert merged 16 commits into
open-feature:mainfrom
chrfwow:add-vmlens

Conversation

@chrfwow

@chrfwow chrfwow commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

This PR

Adds VMLens tests, which should help with finding race conditions and other concurrency issues.

Follow-up Tasks

Add more VMLens tests

@chrfwow chrfwow changed the title add vmlens feat: Add VMLens Tests Dec 2, 2025
@chrfwow

chrfwow commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

Waiting for jamsesso/json-logic-java#65, as VMLens found a race condition in the json-logic library

@chrfwow

chrfwow commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

I disabled the test that finds the race condition in the json logic library. It does not affect us because we do not add json logic operators after application startup, and I don't think the PR to fix the data race will be merged anytime soon

@chrfwow chrfwow marked this pull request as ready for review January 21, 2026 10:54
@chrfwow chrfwow requested a review from a team as a code owner January 21, 2026 10:54

@leakonvalinka leakonvalinka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow and others added 2 commits February 18, 2026 16:42
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert

toddbaert commented Feb 18, 2026

Copy link
Copy Markdown
Member

@chrfwow thanks a lot for this. There was some nasty conflicts, because of recent changes around the FATAL stuff which involved a lot of the SyncResources you changed in this PR. I rebased and resolved them, and moved the new, related tests from main into your new vm-lens enabled tests for the SyncResources (FlagdProviderSyncResourcesCTest).

VMlens runs as expected and I see VMLens results locally, though I also sometimes see "vmlens not configured" errors - I guess this is a log message we expect, perhaps from other modules? I can't make sense of it, because I certainly see the expected VMLens results.

@toddbaert toddbaert merged commit 0856ee9 into open-feature:main Feb 18, 2026
5 checks passed
@chrfwow

chrfwow commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

@toddbaert if I understood it correctly, vmlens runs the tests twice. The first time is just the normal test executions without the vmlens agent attached. This is where the warnings come from. And then a second time with vmlens agent, but also with the filter applied (only tests in files that end with CT.java). I don't know excatly why it does it like this, but running all the tests with the vmlens agent attached led to problems in our pipeline. The architecture tests sometimes never terminated

@chrfwow chrfwow deleted the add-vmlens branch February 19, 2026 07:13
mahpatil pushed a commit to mahpatil/java-sdk-contrib that referenced this pull request Jun 3, 2026
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants