Skip to content

Fix FSP_PHYP to avoid FSP operations and use HMC directly#950

Open
PraveenPenguin wants to merge 1 commit into
open-power:masterfrom
PraveenPenguin:fsp_phyp_fix
Open

Fix FSP_PHYP to avoid FSP operations and use HMC directly#950
PraveenPenguin wants to merge 1 commit into
open-power:masterfrom
PraveenPenguin:fsp_phyp_fix

Conversation

@PraveenPenguin
Copy link
Copy Markdown
Collaborator

When bmc_type is FSP_PHYP, the framework now uses HMC directly as the BMC object instead of creating an OpTestFSP object. This avoids all FSP-specific operations like fsp_get_console() which are not applicable in PHYP environments where all management is done through HMC.

Changes:

  • OpTestHMC: Added get_ipmi(), get_hmc(), bmc_host() methods to make it compatible as a BMC object
  • OpTestConfiguration: Use HMC directly as BMC for FSP_PHYP instead of creating OpTestFSP object
  • OpTestSystem: Skip fsp_get_console() for both FSP_PHYP and EBMC_PHYP as console is managed through HMC

This ensures FSP/BMC-specific operations are avoided when using PHYP BMC types, preventing pexpect and FSP telnet connection issues.

When bmc_type is FSP_PHYP, the framework now uses HMC directly as the
BMC object instead of creating an OpTestFSP object. This avoids all
FSP-specific operations like fsp_get_console() which are not applicable
in PHYP environments where all management is done through HMC.

Changes:
- OpTestHMC: Added get_ipmi(), get_hmc(), bmc_host() methods to make
  it compatible as a BMC object
- OpTestConfiguration: Use HMC directly as BMC for FSP_PHYP instead of
  creating OpTestFSP object
- OpTestSystem: Skip fsp_get_console() for both FSP_PHYP and EBMC_PHYP
  as console is managed through HMC

This ensures FSP/BMC-specific operations are avoided when using PHYP
BMC types, preventing pexpect and FSP telnet connection issues.

Signed-off-by: Praveen K Pandey <praveen@linux.vnet.ibm.com>
@PraveenPenguin PraveenPenguin marked this pull request as draft April 29, 2026 03:46
@abdhaleegit
Copy link
Copy Markdown
Collaborator

@PraveenPenguin we should keep FSP optional still to support legacy.. lets not completely remove whole FSP support code ? how about Baremetal access .. ? this might come up again in future .. if IBM strategy changes ?

@PraveenPenguin
Copy link
Copy Markdown
Collaborator Author

PraveenPenguin commented Apr 30, 2026

@PraveenPenguin we should keep FSP optional still to support legacy.. lets not completely remove whole FSP support code ? how about Baremetal access .. ? this might come up again in future .. if IBM strategy changes ?

@abdhaleegit Thanks for the review. Just to clarify:

This patch does not touch the BMC path. It only skips BMC/FSP access when the system type under PHYP is detected as eBMC or FSP.
Regarding future bare-metal support, that can be evaluated separately when needed. This patch is not related to bare-metal access policy change .

Please let me know if you see any concerns with the current scope of this change.

@PraveenPenguin PraveenPenguin marked this pull request as ready for review May 20, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants