Fix FSP_PHYP to avoid FSP operations and use HMC directly#950
Fix FSP_PHYP to avoid FSP operations and use HMC directly#950PraveenPenguin wants to merge 1 commit into
Conversation
When bmc_type is FSP_PHYP, the framework now uses HMC directly as the BMC object instead of creating an OpTestFSP object. This avoids all FSP-specific operations like fsp_get_console() which are not applicable in PHYP environments where all management is done through HMC. Changes: - OpTestHMC: Added get_ipmi(), get_hmc(), bmc_host() methods to make it compatible as a BMC object - OpTestConfiguration: Use HMC directly as BMC for FSP_PHYP instead of creating OpTestFSP object - OpTestSystem: Skip fsp_get_console() for both FSP_PHYP and EBMC_PHYP as console is managed through HMC This ensures FSP/BMC-specific operations are avoided when using PHYP BMC types, preventing pexpect and FSP telnet connection issues. Signed-off-by: Praveen K Pandey <praveen@linux.vnet.ibm.com>
|
@PraveenPenguin we should keep FSP optional still to support legacy.. lets not completely remove whole FSP support code ? how about Baremetal access .. ? this might come up again in future .. if IBM strategy changes ? |
@abdhaleegit Thanks for the review. Just to clarify: This patch does not touch the BMC path. It only skips BMC/FSP access when the system type under PHYP is detected as eBMC or FSP. Please let me know if you see any concerns with the current scope of this change. |
When bmc_type is FSP_PHYP, the framework now uses HMC directly as the BMC object instead of creating an OpTestFSP object. This avoids all FSP-specific operations like fsp_get_console() which are not applicable in PHYP environments where all management is done through HMC.
Changes:
This ensures FSP/BMC-specific operations are avoided when using PHYP BMC types, preventing pexpect and FSP telnet connection issues.