ci(zizmor): run the push scan on master (default branch), not the non-existent main - #1707
Merged
Merged
Conversation
The default branch is master; there is no main branch, so the push-triggered zizmor scan never runs on the default branch (only PRs are covered). Point it at master so the push scan and code-scanning baseline actually populate.
Contributor
|
Valid. Ideally we would rename master to main but not sure that's worth the breaking changes for consumer of this repository. |
Coverage Report for CI Build 30407968484Coverage remained the same at 89.907%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
.github/workflows/zizmor.ymlruns the security scanner onpushtomain:But this repo's default branch is
master— there is nomainbranch (gh api .../branches/main→ 404). So the push half of the scan never fires on the default branch, and thesecurity-events: writecode-scanning baseline it would populate is never established. Only PRs are covered (via thepull_request: ["**"]trigger).This one-line change points the push trigger at
masterso the scan runs on the default branch as intended.Disclosure: I used an AI tool to help spot this; I verified the default branch and the missing
mainagainst the repo myself and take responsibility for it.