Skip to content

Collect async exemplars when exemplar filter is always_on#8363

Open
ADITYA-CODE-SOURCE wants to merge 6 commits into
open-telemetry:mainfrom
ADITYA-CODE-SOURCE:issue-8355-async-exemplars
Open

Collect async exemplars when exemplar filter is always_on#8363
ADITYA-CODE-SOURCE wants to merge 6 commits into
open-telemetry:mainfrom
ADITYA-CODE-SOURCE:issue-8355-async-exemplars

Conversation

@ADITYA-CODE-SOURCE
Copy link
Copy Markdown
Contributor

@ADITYA-CODE-SOURCE ADITYA-CODE-SOURCE commented May 3, 2026 •
edited
Loading

Summary

Fixes #8355

@ADITYA-CODE-SOURCE
Implement async exemplars for always_on filter
15935f9 
Allow asynchronous metric storage to use the configured exemplar filter so
always_on can capture async exemplars, matching the clarified spec. Add
coverage at both the storage and SDK integration levels.

Refs open-telemetry#8355
@ADITYA-CODE-SOURCE ADITYA-CODE-SOURCE requested a review from a team as a code owner May 3, 2026 08:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (94660eb) to head (3755cf9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #8363   +/-   ##
=========================================
  Coverage     90.87%   90.88%           
- Complexity     7989     7991    +2     
=========================================
  Files           898      898           
  Lines         24119    24119           
  Branches       2412     2412           
=========================================
+ Hits          21919    21920    +1     
+ Misses         1456     1455    -1     
  Partials        744      744

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced May 4, 2026
Open
Open
jack-berg
jack-berg reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. Just one comment, but looks pretty good on the whole

Comment thread sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/SdkMeterProviderTest.java
}

@Test
void collectAll_AsyncInstrumentAlwaysOnExemplars() {
Copy link
Copy Markdown
Member

@jack-berg jack-berg May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests of this shape to:

  • SdkObservableDoubleCounterTest
  • SdkObservableDoubleUpDownCounterTest
  • SdkObservableLongCounterTest
  • SdkObservableLongUpDownCounterTest
  • SdkDoubleGaugeTest
  • SdkLongGaugeTest

Should also add assertions to the default case to ensure that no exemplars are reported.

@ADITYA-CODE-SOURCE
Copy link
Copy Markdown
Contributor Author

ADITYA-CODE-SOURCE commented May 12, 2026

@jack-berg Thanks for the review. I added the requested async exemplar coverage to the six instrument test classes you called out, and I also added default-case assertions to verify that no exemplars are reported unless always_on is configured.\n\nI ran the focused sdk:metrics test suite for the touched classes locally, and the updated branch is pushed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jack-berg jack-berg jack-berg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Async instruments should collect exemplars when filter is set to always on

2 participants

@ADITYA-CODE-SOURCE @jack-berg