Skip to content

Add toString to ComposableAnnotatingSampler #8645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Draft

Add toString to ComposableAnnotatingSampler #8645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableAnnotatingSampler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,9 @@ public SamplingIntent getSamplingIntent(
public String getDescription() {
return description;
}

@Override
public String toString() {
return getDescription();
}
}
16 changes: 16 additions & 0 deletions ...opentelemetry/sdk/extension/incubator/trace/samplers/ComposableAnnotatingSamplerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,22 @@ void testDescription() {
"ComposableAnnotatingSampler{ComposableAlwaysOnSampler,{http.route=\"/bear\", size=100}}");
}

@Test
void descriptionInComposedSampler() {
// The annotating sampler must override toString() so that samplers composing it (which build
// their description by concatenating the nested sampler) surface its real description instead
// of
// an Object hash.
String description =
ComposableSampler.parentThreshold(
ComposableSampler.annotating(ComposableSampler.alwaysOn(), Attributes.empty()))
.getDescription();
assertThat(description)
.isEqualTo(
"ComposableParentThresholdSampler{rootSampler=ComposableAnnotatingSampler{ComposableAlwaysOnSampler,{}}}");
assertThat(description).doesNotContain("@");
}

@Test
void setsAttributes() {
SamplingIntent intent =
Expand Down
Loading