Skip to content

Fix inaccurate ServiceInstanceIdResourceProvider class Javadoc#8647

Draft
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:docs/service-instance-id-provider-javadoc
Draft

Fix inaccurate ServiceInstanceIdResourceProvider class Javadoc#8647
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:docs/service-instance-id-provider-javadoc

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Fixes #8646

Description

  • The class Javadoc claimed the provider "does not implement ResourceProvider", which is false: it implements ConditionalResourceProvider, and ConditionalResourceProvider extends ResourceProvider.
  • The old text was also a subjectless sentence fragment.
  • Rewrote it to explain the provider uses ConditionalResourceProvider rather than a plain ResourceProvider because it runs after the other providers have discovered their attributes.
  • Javadoc-only; no code, signature, or behavior change.

Testing done

  • Docs-only, test-exempt: no test added. ./gradlew :sdk-extensions:incubator:check passed (spotless + ErrorProne/NullAway + jApiCmp + tests).
  • No apidiff change (alpha module, Javadoc-only).

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 19, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-20 21:23:43 UTC.

  • Waiting on: Author
  • Next step: Move out of draft to request review.

This automated status or its linked feedback items may be incorrect. If something looks wrong, report it with the result you expected.

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.64%. Comparing base (09d6c17) to head (542b9d3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8647   +/-   ##
=========================================
  Coverage     91.64%   91.64%           
  Complexity    10348    10348           
=========================================
  Files          1013     1013           
  Lines         27380    27380           
  Branches       3218     3218           
=========================================
  Hits          25092    25092           
  Misses         1558     1558           
  Partials        730      730           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix inaccurate ServiceInstanceIdResourceProvider class Javadoc

1 participant