Skip to content

opentelemetry-test-utils: skip installing grpc exporter only on Pypy #5178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xrmx wants to merge 7 commits into
base: main
Choose a base branch
from
+4 −5
Open

opentelemetry-test-utils: skip installing grpc exporter only on Pypy #5178

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
28bbd8f
opentelemetry-test-utils: move requirements environment markers to a …
xrmx May 5, 2026
4051a5a
Second try
xrmx May 5, 2026
ccc8ad7
Apply suggestions from code review
emdneto May 5, 2026
1ee8b0c
Update tox.ini
emdneto May 5, 2026
452af7c
Update dependency paths in test-requirements.txt
emdneto May 8, 2026
9a9a7e2
Merge branch 'main' into fix-dependabot-test-utils
xrmx May 8, 2026
b42d745
Skip only on pypy since installation of requirements on windows seems…
xrmx May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/opentelemetry-test-utils/test-requirements.txt
View file
Open in desktop
Copy link
Copy Markdown
Member

@emdneto emdneto May 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we use the uv pip compile --python 3.10 --universal ... to generate the requirements.txt? It should solve the grpcio installation issues:

uv pip compile --python 3.10 --resolution lowest --universal tests/opentelemetry-test-utils/test-requirements.in -o tests/opentelemetry-test-utils/test-requirements.txt

Copy link
Copy Markdown
Member

@emdneto emdneto May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated test-requirements.txt

# This file was autogenerated by uv via the following command:
#    uv pip compile --python 3.10 --resolution lowest --universal tests/opentelemetry-test-utils/test-requirements.in -o tests/opentelemetry-test-utils/test-requirements.txt
-e exporter/opentelemetry-exporter-otlp-proto-common
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   opentelemetry-exporter-otlp-proto-grpc
-e exporter/opentelemetry-exporter-otlp-proto-grpc
    # via -r tests/opentelemetry-test-utils/test-requirements.in
-e opentelemetry-api
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   opentelemetry-exporter-otlp-proto-grpc
    #   opentelemetry-sdk
    #   opentelemetry-semantic-conventions
    #   opentelemetry-test-utils
-e opentelemetry-proto
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   opentelemetry-exporter-otlp-proto-common
    #   opentelemetry-exporter-otlp-proto-grpc
-e opentelemetry-sdk
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   opentelemetry-exporter-otlp-proto-grpc
    #   opentelemetry-test-utils
-e opentelemetry-semantic-conventions
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   opentelemetry-sdk
-e tests/opentelemetry-test-utils
    # via -r tests/opentelemetry-test-utils/test-requirements.in
asgiref==3.7.2
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   opentelemetry-test-utils
certifi==2017.4.17
    # via requests
charset-normalizer==2.0.0
    # via requests
colorama==0.1 ; sys_platform == 'win32'
    # via pytest
exceptiongroup==1.0.0 ; python_full_version < '3.11'
    # via pytest
googleapis-common-protos==1.63.1
    # via opentelemetry-exporter-otlp-proto-grpc
grpcio==1.63.2 ; python_full_version < '3.13'
    # via opentelemetry-exporter-otlp-proto-grpc
grpcio==1.66.2 ; python_full_version == '3.13.*'
    # via opentelemetry-exporter-otlp-proto-grpc
grpcio==1.75.1 ; python_full_version >= '3.14'
    # via opentelemetry-exporter-otlp-proto-grpc
idna==2.5
    # via requests
importlib-metadata==6.11.0
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   opentelemetry-api
iniconfig==2.0.0
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   pytest
packaging==24.0
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   pytest
pluggy==1.6.0
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   pytest
protobuf==5.26.0
    # via
    #   googleapis-common-protos
    #   opentelemetry-proto
py-cpuinfo==9.0.0
    # via -r tests/opentelemetry-test-utils/test-requirements.in
pytest==7.4.4
    # via -r tests/opentelemetry-test-utils/test-requirements.in
requests==2.28.0
    # via opentelemetry-test-utils
tomli==2.0.1
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   pytest
typing-extensions==4.12.0
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   asgiref
    #   grpcio
    #   opentelemetry-api
    #   opentelemetry-exporter-otlp-proto-grpc
    #   opentelemetry-sdk
    #   opentelemetry-semantic-conventions
urllib3==1.21.1
    # via requests
wrapt==1.16.0
    # via -r tests/opentelemetry-test-utils/test-requirements.in
zipp==3.19.2
    # via
    #   -r tests/opentelemetry-test-utils/test-requirements.in
    #   importlib-metadata

Copy link
Copy Markdown
Member

@emdneto emdneto May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-requirements.in

asgiref==3.7.2
importlib-metadata==6.11.0
iniconfig==2.0.0
packaging==24.0
pluggy==1.6.0
py-cpuinfo==9.0.0
pytest==7.4.4
tomli==2.0.1
typing_extensions==4.12.0
wrapt==1.16.0
zipp==3.19.2
-e opentelemetry-api
-e opentelemetry-sdk
-e opentelemetry-semantic-conventions
-e opentelemetry-proto
-e tests/opentelemetry-test-utils
-e exporter/opentelemetry-exporter-otlp-proto-common
-e exporter/opentelemetry-exporter-otlp-proto-grpc

Copy link
Copy Markdown
Contributor Author

@xrmx xrmx May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my last comment, on windows the test-utils job takes < 1 minute even if we install the grpc exporter so that's not a problem anymore. So I'll give it a try with just skipping pypy and see if dependabot is happy again before introducing another step to build these.

Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ zipp==3.19.2
-e opentelemetry-semantic-conventions
-e tests/opentelemetry-test-utils
# these are required for weaver integration tests, we're running that only on linux / CPython
# because of lack of support for gRPC on Windows in some cases.
# note: tox does not support PEP 508 markers on `-e` editable installs, so these are installed non-editable
./opentelemetry-proto ; sys_platform != 'win32' and platform_python_implementation != 'PyPy'
./exporter/opentelemetry-exporter-otlp-proto-common ; sys_platform != 'win32' and platform_python_implementation != 'PyPy'
./exporter/opentelemetry-exporter-otlp-proto-grpc ; sys_platform != 'win32' and platform_python_implementation != 'PyPy'
# because of lack of support for gRPC wheels on some platforms
./opentelemetry-proto ; platform_python_implementation != 'PyPy'
./exporter/opentelemetry-exporter-otlp-proto-common ; platform_python_implementation != 'PyPy'
./exporter/opentelemetry-exporter-otlp-proto-grpc ; platform_python_implementation != 'PyPy'
Loading