Skip to content

Fix: Address-family mismatch confirmed: the shared mock server in test_otlp_e #5530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M001N wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −5
Open

Fix: Address-family mismatch confirmed: the shared mock server in test_otlp_e #5530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_exporter_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ class OTLPSpanExporterForTesting(
],
):
def __init__(self, **kwargs):
# Default to the explicit IPv4 loopback address rather than
# "localhost", which can resolve to the IPv6 loopback address
# ("::1") first depending on the OS/environment. The mock server
# used by these tests only binds to 127.0.0.1, so resolving
# "localhost" to ::1 would cause tests to try to connect to an
# unrelated service (if any) listening on ::1:4317 instead of the
# mock server, producing confusing, environment-dependent failures.
kwargs.setdefault("endpoint", "http://127.0.0.1:4317")
super().__init__(
TraceServiceStub,
SpanExportResult,
Expand Down Expand Up @@ -277,7 +285,7 @@ def test_otlp_exporter_otlp_compression_unspecified(self, mock_insecure_channel)
"""No env or kwarg should be NoCompression"""
OTLPSpanExporterForTesting(insecure=True)
mock_insecure_channel.assert_called_once_with(
"localhost:4317",
"127.0.0.1:4317",
compression=Compression.NoCompression,
options=(
(
Expand Down Expand Up @@ -339,7 +347,7 @@ def test_otlp_exporter_otlp_compression_envvar(self, mock_insecure_channel):
"""Just OTEL_EXPORTER_OTLP_COMPRESSION should work"""
OTLPSpanExporterForTesting(insecure=True)
mock_insecure_channel.assert_called_once_with(
"localhost:4317",
"127.0.0.1:4317",
compression=Compression.Gzip,
options=(
(
Expand Down Expand Up @@ -529,7 +537,7 @@ def test_timeout_set_correctly(self):
)
after = time.time()
self.assertEqual(
"Failed to export traces to localhost:4317, error code: StatusCode.DEADLINE_EXCEEDED, error details: Deadline Exceeded",
"Failed to export traces to 127.0.0.1:4317, error code: StatusCode.DEADLINE_EXCEEDED, error details: Deadline Exceeded",
warning.records[-1].message,
)
self.assertEqual(mock_trace_service.num_requests, 2)
Expand Down Expand Up @@ -565,7 +573,7 @@ def test_permanent_failure(self):
self.assertEqual(exporter.export([self.span]), SpanExportResult.FAILURE)
self.assertEqual(
warning.records[-1].message,
"Failed to export traces to localhost:4317, error code: StatusCode.ALREADY_EXISTS, error details: This already exists.",
"Failed to export traces to 127.0.0.1:4317, error code: StatusCode.ALREADY_EXISTS, error details: This already exists.",
)

metrics_data = self.metric_reader.get_metrics_data()
Expand Down Expand Up @@ -683,5 +691,5 @@ def test_retryable_error_codes_custom(self):
def assert_standard_metric_attrs(self, attributes):
self.assertEqual(attributes["otel.component.type"], "otlp_grpc_span_exporter")
self.assertTrue(attributes["otel.component.name"].startswith("otlp_grpc_span_exporter/"))
self.assertEqual(attributes["server.address"], "localhost")
self.assertEqual(attributes["server.address"], "127.0.0.1")
self.assertEqual(attributes["server.port"], 4317)
Loading