opentelemetry-sdk: fix values for process.executable resource attributes - #5535
Open
xrmx wants to merge 2 commits into
Open
opentelemetry-sdk: fix values for process.executable resource attributes#5535xrmx wants to merge 2 commits into
xrmx wants to merge 2 commits into
Conversation
Per registry [1]: - process.executable.name should be the base name of the executable - process.executable.path should be the full path of the executable Now for name we sent the full path and for path only the parent directory. [1] https://opentelemetry.io/docs/specs/semconv/registry/attributes/process/
xrmx
changed the title
Contributor
Author
|
Would appreciate if anyone on windows can double check what does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per registry [1]:
Now for name we send the full path and for path only the parent directory.
[1] https://opentelemetry.io/docs/specs/semconv/registry/attributes/process/
Spotted this when looking at #5459
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: