Skip to content

Allow users to swap the order of sensors while editing the sensor details#830

Open
JerryVincent wants to merge 1 commit intodevfrom
feat/alterSensorOrder
Open

Allow users to swap the order of sensors while editing the sensor details#830
JerryVincent wants to merge 1 commit intodevfrom
feat/alterSensorOrder

Conversation

@JerryVincent
Copy link
Collaborator

@JerryVincent JerryVincent commented Mar 18, 2026

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

I have implemented the swapping of sensor order while editing the sensor details. The new order is saved in the database, so that it persists.

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

…the new order. Also fixed the issue of swapping the unit and sensor type values after editing and saving them.
@github-actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.24% 1670 / 2344
🔵 Statements 69.55% 1741 / 2503
🔵 Functions 73.17% 341 / 466
🔵 Branches 58.14% 928 / 1596
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/models/sensor.server.ts 65.9% 66.66% 47.05% 67.44% 70-72, 119-124, 149-208, 262
app/schema/sensor.ts 85.71% 100% 75% 83.33% 42
Generated in workflow #2234 for commit 7a9a194 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editing a phenomenon unit from the UI results in changing the sensor type and vice-verca Allow users to change the order of phenomenons of a device

1 participant