fix(sdk): keep restored scan artifacts within their output directory - #468
fix(sdk): keep restored scan artifacts within their output directory#468mldangelo-oai wants to merge 3 commits into
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Keep completed scan artifact restoration within the selected scan output directory.
Changes
Testing
bun test --timeout 30000 tests-ts/api-post-scan.test.ts tests-ts/contract.test.ts— 35 passed, 0 failed.bun test --timeout 30000 --randomize --seed 12345 ./tests-tswith JUnit reporting — 1,294 passed, 11 skipped, 0 failed across 63 files. The skips cover Windows-only tests and the opt-in real-service integration smoke.pnpm run types— passed.pnpm run format— passed.git diff --check 5d1afcd312933121e36dc892dcb12e8d2e3e1de3...HEAD— passed.4ca4c82b4f14ede84e666742c52639391a127384.Risk and rollout
Normal completed-artifact restoration remains unchanged. Public contract readers keep their existing path canonicalization, including supported output directories beneath directory links. Restoration now uses the same non-symlink artifact-parent requirement as completed-contract reads and stops if the approved canonical output root has changed. No public SDK export or dependency is added.
Public disclosure review
Newly authored material was reviewed for public disclosure. Existing automated review comments contain access-restricted report references; maintainer cleanup remains outstanding.