feat(cli): review and apply saved SECURITY.md drafts - #489
feat(cli): review and apply saved SECURITY.md drafts#489mldangelo-oai wants to merge 50 commits into
Conversation
|
@codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: b1de4d9394
Only the user who started this review can view the report in Codex.
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
# Conflicts: # sdk/typescript/README.md # sdk/typescript/src/security-policy-cli.ts # sdk/typescript/src/security-policy.ts # sdk/typescript/tests-ts/security-policy.test.ts
# Conflicts: # README.md # sdk/typescript/README.md
# Conflicts: # sdk/typescript/src/security-policy-cli.ts # sdk/typescript/tests-ts/cli-policy.test.ts
…dex/security-policy-stack-cleanup
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review The final testing notes are updated. The head is still |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Let an owner apply a
SECURITY.mddraft after reviewing it. Interactive generation shows the exact diff and asks before writing.--applyloads a saved draft without calling the model.The remaining stack is #510 for shared command helpers, #536 for read-only drafting, and this PR for review and application. #485 and #505 have merged. The branch includes
mainthrough8a531126.Changes
Use the original repository and
--pathwhen applying a component draft.--writerequires an existing saved draft; it does not generate one.Testing
Checks on
8ecde8cb:pnpm run typesandpnpm run format: passed.12345: 1,475 passed, 11 skipped, 0 failed in each run.pnpm packand the package checker: passed, including installed CLI/SDK and bundled-runtime smoke tests.The first CI run exposed a test fixture that relied on a locally installed Python. The fixture now uses its known test interpreter. No test timeouts changed.
Risk and rollout
Merge #510 and #536 first. Applying replaces the selected
SECURITY.mdand may retain the previous file for recovery. It does not stage, commit, or publish the policy. After interrupted verification, rerun the same saved draft. Keep any reported recovery file until concurrent edits are reconciled. This adds no npm dependencies, does not change saved scan results, and does not publish a package.Public disclosure review
An existing automated review contains a report link that is visible only to its requester. That link and report are not reproduced here.