[codex] Harden GitHub Actions permissions#762
Open
jbeckwith-oai wants to merge 1 commit into
Open
Conversation
81a48e0 to
f0a1f5f
Compare
f0a1f5f to
28597ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contents: readdefaults to all GitHub Actions workflows.GITHUB_TOKENcredentials in checkout steps.mainpushes.Why
The repository currently has write-capable default workflow permissions, so jobs without explicit
permissions:blocks inherit broaderGITHUB_TOKENaccess than they need. The previous CI build job also granted OIDC to the whole job while running pull request code, even though only the artifact upload path needed it.The prior PR run also failed in
LoggingHttpClientTest.debugLevel_logsRequestBody(false)because JVM dynamic-agent warnings from Mockito/Byte Buddy were written to stderr and polluted exact log assertions. Enabling dynamic agent loading for test JVMs removes that warning at the source while preserving the assertion behavior.Validation
origin/mainand rebased this branch cleanly on2935d47e753fcbef81a6a0d720eedb3ac559ac73.YAML.load_file.git diff --check.pull_request_target,workflow_run, andsecrets: inherit.Local Gradle execution is blocked on this machine because the default JDK is Java 25.0.2, which this Gradle/Kotlin stack cannot parse during build-script compilation. GitHub Actions uses Java 21 and is the authoritative validation for the test fix.
Follow-up outside this PR
The repo-level Actions setting should still be flipped from default workflow permission
writetoread, and "Allow GitHub Actions to create and approve pull requests" should be disabled in repository settings. Those are admin settings rather than repository files.